fix: bundled-source.js - transformed source map is saved to cache.
#1216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cp
requested changes
Aug 6, 2025
Member
3cp
left a comment
3cp
left a comment
There was a problem hiding this comment.
Looks good. Just one small suggestion.
lib/build/bundled-source.js
Outdated
Comment on lines
22
to
24
| return this._transformedSourceMap === null | ||
| ? this.file.sourceMap | ||
| : this._transformedSourceMap; |
Member
There was a problem hiding this comment.
I think you can just do return this._transformedSourceMap || this.file.sourceMap;.
Contributor
Author
There was a problem hiding this comment.
I adopted the suggested change and I also added check when caching - if property _transformedSourceMap is null, cache value is set to undefined, so it's skipped in JSON.stringify. No need to cache null values.
3cp
approved these changes
Aug 7, 2025
Member
|
@bigpon another patch release pls. |
Member
|
3.0.7 has been released, thanks @nenadvicentic @3cp 🙏 |
Contributor
Author
nenadvicentic
added a commit
to nenadvicentic/aurelia-cli
that referenced
this pull request
Aug 7, 2025
…r is outside of project's root folder (aurelia#1213) + fix: `bundled-source.js` - transformed source map is saved to cache. (aurelia#1216)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous pull request #1215 did not take in consideration
BundledSourcecache, so we would get correct source map only on firstau build. Secondau build, without source file change, when cache is used, CLI would fallback to originalfile.sourceMap, because transformed source map was not cached.Issue is now fixed:
_transformedSourceMapproperty, to differentiate fromfile.sourceMap._transformedSourceMapsaved/read from cache.bundled-source.spec.js. They are variation on 2 existing cache tests.build.options.cacheon and off.